search

gabrielbull / react-desktop

React UI Components for macOS High Sierra and Windows 10
http://reactdesktop.js.org
MIT License
9.51k stars 462 forks source link

Switch from radium to styled-components #112

Open gabrielbull opened 6 years ago

gabrielbull commented 6 years ago

What are the pros and cons of those three solutions?

Which one is the most adapted for a component library?

The new library should allow for extending proposed in #113

Switch react-desktop from radium to styled-components. Can be done progressively.

Need to provide multiple ways for the user to extend the style of a component, including className property, style property, etc.

yordis commented 6 years ago

Between those,

Definitely styled-components.

Emotion is fine as well but you will no have the same support and some missing features compare to styled-components.

SASS, to be honest, I have almost a year without touching anything outside of JSCSS and unless I have to jump to something outside of React I will keep using styled-components or any other implementation of JSCSS

alacroix commented 6 years ago

I used styled-components for about 9 months now, I'm pretty convinced of the utility of CSS-in-JS. Writing pure SASS makes us lose a huge amount of flexibility.

When you say "missing features" about emotion @yordis, do you have more details? All I can find on different issues is that both are pretty much the same, with emotion being more smaller and faster.

gabrielbull commented 6 years ago

Seems like everyone is on-board with styled-components. As for styled-components vs emotion, if they are on par, I think it would be wiser to use styled-components as it has a much bigger user base, with 13 462 stars on Github vs 2 822 for emotion.

yordis commented 6 years ago

@alacroix https://github.com/emotion-js/emotion/issues/113#issuecomment-334955156

yordis commented 6 years ago

@gabrielbull also the version 3.1 is much faster than before https://twitter.com/mxstbr/status/957905553044463621

alacroix commented 6 years ago

Let's go for styled-components then 👍

bakhaa commented 5 years ago

I can help with styled-components.

davej commented 5 years ago

Happy to review and merge PRs if anyone wants to make a start.

AndrewKralovec commented 5 years ago

As mentioned in issue-129 , lets keep mind theming for the two operating systems.

https://www.styled-components.com/docs/advanced

pixelass commented 5 years ago

I this suggestion still under consideration?

Since I'm currently building an OS X component library with styled-components (supporting light & dark mode) I might be open to contribute.

davej commented 5 years ago

@pixelass Yes, I would be happy to review any contributions.

pixelass commented 5 years ago

Right now I'm building things from scratch but I'll look into this library and see if I can at least add a DRAFT for some new components.