search

gabrielbull / react-desktop

React UI Components for macOS High Sierra and Windows 10
http://reactdesktop.js.org
MIT License
9.52k stars 462 forks source link

:active class lost for Button component #115

Closed alacroix closed 6 years ago

alacroix commented 6 years ago

Hey @gabrielbull,

I was trying to implement styled-components on the Button component but I wasn't able to get the active effect on the playground.

I suspect the update of Radium to version ^0.21.2 on this commit to be the culprit.

If I reset to the old version, it works again. I didn't test on other components but I suspect every :active and other Radium style to be broken right now.

Maybe downgrade Radium version for now or check the breaking changes for the updated version while we switch to styled-components

gabrielbull commented 6 years ago

Ok, I reverted radium back to "=0.19.6" on the master branch. Can you publish a branch with your changes so I can play around as well? Maybe call it styled-components. Thanks!

alacroix commented 6 years ago

@gabrielbull, sure! I'm on jest right now but when I'll resume my work on styled-components, i'll push what i've done 👍

alacroix commented 6 years ago

Fixed with 15c92fba7765a0a8077d6990d43a985da4ae5738