Integrate with electron-react-boilerplate style problem

gabrielbull / react-desktop

React UI Components for macOS High Sierra and Windows 10

http://reactdesktop.js.org

MIT License

9.52k stars 462 forks source link

Integrate with electron-react-boilerplate style problem #64

Closed xgenvn closed 8 years ago

xgenvn commented 8 years ago

I'm trying to integrate react desktop components into a boilerplate by electron-react-boilerplate. Already set the frame option to false, tweak the margin to zero, I got the overflow scrollbar:

If I set the body style to overflow: hidden, the border of main window won't be able to display (due to overflow). In the snip below, right border is not showing.

Since the stylesheet of the boilerplate is pretty simple, I'm not really sure whether I miss any option. Any suggestion will be appreciated.

gabrielbull commented 8 years ago

Can you zip and share the boilerplate you made?

xgenvn commented 8 years ago

This is just a basic boilerplate with some tweaks I mentioned above. Actually, the original repo suggests react-desktop for native looking, so I try to integrate into the sample project and there goes some UI issues. electron-react-boilerplate.zip

gabrielbull commented 8 years ago

Hi. I just released a new version containing a fix for your issue. Please update your react-desktop dependency to 0.2.12. Thanks for reporting the issue, let me know if there are any more issues.

xgenvn commented 8 years ago

Awesome! I have checked again and updated to last version, the issue is solved perfectly. Thank you.