search

gabrielbull / react-desktop

React UI Components for macOS High Sierra and Windows 10
http://reactdesktop.js.org
MIT License
9.51k stars 461 forks source link

Switch tests to Jest #96

Open okonet opened 7 years ago

okonet commented 7 years ago

I believe this will make contributions to this project easier. Recently I created a PR and wanted to add some tests but noticed that there are no tests for any interactions yet so I would need to make a choice of a mocking framework (Sinon?) but ideally I'd just jump into writing tests. Jest comes as a feature-reach testing framework that has everything needed to test React components bundled (snapshot testing is amazing BTW, mocking, promises etc.).

Would you consider switching to Jest if I would create a PR?

gabrielbull commented 7 years ago

Hi okonet, yes I would be open to switching to Jest. When I first created this project, I had not used Jest, but since then, I have and think it would be a good idea as well. Bring on the PR. Would you like to be part of this project as a maintainer, I am looking for help since my time is very limited?

okonet commented 7 years ago

Hey @gabrielbull! I'll try to do my best but maintaining one more project is off the table since I'm also fighting for me free time now.

okonet commented 7 years ago

By saying that I mean I wouldn't not take over it but I could be involved in some discussions. So up to you if you want to invite me as a member or not :)

gabrielbull commented 7 years ago

Invited you, so now its your responsibility 🏃‍♂️ (runs away). J/K but any help is welcome at this point.