search

gabrielcsapo / node-git-server

🎡 A configurable git server written in Node.js
https://gabrielcsapo.github.io/node-git-server
MIT License
253 stars 73 forks source link

Removes dependency on http-duplex package replacing w/ internal replacement lib #24

Closed echopoint closed 6 years ago

echopoint commented 6 years ago

Examined and wrote a different version of the proxy object that http-duplex supplies without additional dependencies. Removed node's util.inherits because it seems they are looking to deprecate that way of inheriting objects. Tested locally with an 80GB repo and didn't have any issues with passing data over it. Please test and let me know of any errors. Should take care of https://github.com/gabrielcsapo/node-git-server/issues/7

gabrielcsapo commented 6 years ago

@echopoint you rock! Would you mind adding yourself to the contributors section of the package.json? I tested this locally and it is fast! Awesome!

echopoint commented 6 years ago

Fixed.. sorry about the extraneous commit :/

gabrielcsapo commented 6 years ago

@echopoint no problem! let me get this merged and published!

gabrielcsapo commented 6 years ago

published in https://github.com/gabrielcsapo/node-git-server/releases/tag/0.3.3 :) you rock @echopoint!

plunkettscott commented 6 years ago

Excellent PR!