search

gabrielcsapo / node-git-server

🎡 A configurable git server written in Node.js
https://gabrielcsapo.github.io/node-git-server
MIT License
253 stars 73 forks source link

updates duplex lib to fix cork,uncork and add some chaining #27

Closed echopoint closed 6 years ago

echopoint commented 6 years ago

cork, uncork needed to actually work. These along with writeHead are also chainable now.

gabrielcsapo commented 6 years ago

🙌 awesome! What is the implication of these not working? Not being able to properly use them in the handlers?

echopoint commented 6 years ago

Any consumer of HttpDuplex wouldn't be able to cork / uncork the response stream. Since I'm using this lib too, I ran into this with buffering the response until headers are complete. I couldn't find any reference to cork/uncork used in the server but better safe than sorry.

gabrielcsapo commented 6 years ago

@echopoint released in https://github.com/gabrielcsapo/node-git-server/releases/tag/0.3.4