search

gabrielcsapo / node-git-server

🎡 A configurable git server written in Node.js
https://gabrielcsapo.github.io/node-git-server
MIT License
253 stars 73 forks source link

Added HTTPS Support And Added The Path Module To The Example Code #34

Closed oscartbeaumont closed 6 years ago

gabrielcsapo commented 6 years ago

@oscartbeaumont can you add a entry into CHANGELOG.md under a heading of # Unreleased with a bulleted list of the changes.

gabrielcsapo commented 6 years ago

@oscartbeaumont there are lint errors that is why the CI is failing.

@echopoint thoughts on the changes?

gabrielcsapo commented 6 years ago

@oscartbeaumont the interface has changed from listen(options) to listen(type, options) I think this is a little too complex as this change should have only required a few lines to get the functionality you want.

echopoint commented 6 years ago

Comments in the documentation should follow jsdoc annotations so anything like tutorials and notes, etc should show up when docs are regenerated. Outside of that I think you covered the base. I'll look it over more in depth this morning.

gabrielcsapo commented 6 years ago

@oscartbeaumont as seen here https://github.com/gabrielcsapo/node-git-server/pull/35 this is a simple backwards compatible change with the small tweaks I was suggesting, if you would like to implement like this I would be more open to a small change rather than a very complex addition.

echopoint commented 6 years ago

Looking over this pr, #35 is more appropriate. This addition shouldn't have been this complicated. No offense intended. Let's ball up the example into the new PR, and verify everything works and go from there.

gabrielcsapo commented 6 years ago

@oscartbeaumont I am going to close this in favor of #35 as it maintains backwards compatibility and the implementation is more flexible.