gabrielcsapo / node-git-server

🎡 A configurable git server written in Node.js
https://gabrielcsapo.github.io/node-git-server
MIT License
253 stars 73 forks source link

Add callback argument to close method #45

Closed mojavelinux closed 5 years ago

mojavelinux commented 5 years ago

In order for the calling code to be properly wait for the server to shutdown, it needs to be able to pass a callback to the close method so it gets notified of the close event.

await new Promise((resolve, reject) =>
  repos.close((err) => err ? reject(err) : resolve())
)

Currently, it's necessary to use the close method on the server property directly.

await new Promise((resolve, reject) =>
  repos.server.close((err) => err ? reject(err) : resolve())
)