Parameterise tests with `ctr_client` in `test_container.py`

gabrieldemarmiesse / python-on-whales

An awesome Python wrapper for an awesome Docker CLI!

MIT License

557 stars 102 forks source link

Parameterise tests with `ctr_client` in `test_container.py` #531

Closed LewisGaul closed 9 months ago

LewisGaul commented 9 months ago

Parameterise test_container.py with podman. Note tests using the docker_registry not currently parameterised (wasn't working with podman when I tried it). Some tests marked as xfail for podman for now (note --runxfail is useful for bulk fixing xfail tests).

Also added a testcase that doesn't rely on mocking for checking podman's systemd mode works, now that this is supported by the test infra.

Progress towards https://github.com/gabrieldemarmiesse/python-on-whales/issues/353

gabrieldemarmiesse commented 9 months ago

I'll merge this PR, let's continue the discussion about strict xfail here: https://github.com/gabrieldemarmiesse/python-on-whales/issues/353