Add support for 'docker version' and 'podman version'

gabrieldemarmiesse / python-on-whales

An awesome Python wrapper for an awesome Docker CLI!

MIT License

537 stars 100 forks source link

Add support for 'docker version' and 'podman version' #593

Closed LewisGaul closed 3 months ago

LewisGaul commented 3 months ago

Fixes https://github.com/gabrieldemarmiesse/python-on-whales/issues/591

[x] Resolve what to do about the added requirement for pydantic v2
- Making it work with pydantic v1 for now (although podman's APIVersion and BuiltTime fields won't be recognised with pydantic v1)
- Raised separate issue for removing pydantic v1 support: https://github.com/gabrieldemarmiesse/python-on-whales/issues/594
[x] Add tests

gabrieldemarmiesse commented 3 months ago

I would be happy to drop support for pydantic V1 when it's end of life, so in one month. If this PR is not a pressing matter, we can merge it just after :)

LewisGaul commented 3 months ago

Looks good as usual! We can merge when pydantic v1 is EOL

To be clear, I updated it to be compatible with pydantic v1 so that we don't need to wait.

gabrieldemarmiesse commented 3 months ago

Ho my bad, I went over it a bit too quickly since I already read the diff once. Let's merge it now :)