search

gabrieldemarmiesse / python-on-whales

An awesome Python wrapper for an awesome Docker CLI!
MIT License
557 stars 102 forks source link

Add Tuple[Union[str, int]] to ValidPortMapping #619

Closed eclark0426 closed 2 months ago

eclark0426 commented 3 months ago

Fixes #601

LewisGaul commented 2 months ago

Is there a testcase that verifies passing a port forwarding rule in this form actually works?

eclark0426 commented 2 months ago

Looks like there is one already: https://github.com/gabrieldemarmiesse/python-on-whales/blob/682ff914a0a0461dc7cb1e63a9d68ee3fa30e09b/tests/python_on_whales/components/test_container.py#L157-L167