search

gabrieldemian / vincenzo

A BitTorrent client with vim-like keybindings and a terminal based UI.
https://github.com/gabrieldemian/vincenzo
MIT License
144 stars 7 forks source link

Consistent test names #7

Closed gabrieldemian closed 1 year ago

gabrieldemian commented 1 year ago

The test names are not consistent, some tests are using "should_", and others are not. Some tests could have more descriptive names, and maybe more comments, where applicable, to help to understand what the test is supposed to do.

crsche commented 1 year ago

I'll give this a shot. I'm a bit new to PRs and whatnot but I have a decent amount of Rust experience.

gabrieldemian commented 1 year ago

I'll give this a shot. I'm a bit new to PRs and whatnot but I have a decent amount of Rust experience.

Sounds great, thanks in advance! PRs are easy to work with, you just create a new branch, push your changes, and then you use github to make the PR.