While no functionality has been changed, this pull request is a major overhaul of the code structure.
I did previously warn you that I would come in with a pretty massive PR. While this one does not add the Scorm 2004 API yet, it does lay the groundwork that will allow me to easily add that API to the project.
I am well aware that this is a lot to take in, especially on a monday morning. I am open to discussion, suggestions, etc.
Major changes:
Split functionality in different files
Added Grunt to build the single output file, as well as a minified output file
Changed code styling standards to fit my own personal style, and added ESLint to ensure these standards are maintained in the future
Changed indentation from 4 spaces to 2 spaces
Collapsed if-else blocks a little (no newline between } and else. etc.)
Grouped object properties with their getter and setter functions
Collapsed getter and setter functions to single lines where possible, using ternary operators when relevant
To build the project, a first npm install needs to be done, then:
(optional) Increment project version in the package.json file
While no functionality has been changed, this pull request is a major overhaul of the code structure.
I did previously warn you that I would come in with a pretty massive PR. While this one does not add the Scorm 2004 API yet, it does lay the groundwork that will allow me to easily add that API to the project.
I am well aware that this is a lot to take in, especially on a monday morning. I am open to discussion, suggestions, etc.
Major changes:
}
andelse
. etc.)To build the project, a first
npm install
needs to be done, then:package.json
filegrunt