Fix listeners always being called if they specified a CMIElement

gabrieldoty / simplify-scorm

Scorm 1.2 Javascript API

MIT License

235 stars 77 forks source link

Fix listeners always being called if they specified a CMIElement #9

Closed xob closed 6 years ago

xob commented 6 years ago

Also, a few improvements:

DRYed up code that checks the API's currentState, which allowed write-to-read-only-attribute-before-initialization algorythms to become one-liners
Prevent SCOs from changing data after LMSFinish has been called
Removed unnecessary jsonString attributes (undefined is falsy)

xob commented 6 years ago

Regarding explicit if / else statements vs inline statements, I also prefer explicit, except for guard clauses. I have grown to love guard clauses in Ruby, and my adaptation for those in javascript is to inline them.