Can't run ITER2D notebook

gabriele-ferrero / Titans_TT_codecomparison

A code comparison study between 3 different Tritium transport codes for the TITANS project

MIT License

0 stars 1 forks source link

Can't run ITER2D notebook #10

Closed RemDelaporteMathurin closed 1 month ago

RemDelaporteMathurin commented 1 month ago

I'm trying to run the ITER2D notebook in Festim models/Jupyter_notebooks and I can't run it because it doesn't find the materials module.

I notice a lot of code duplication between jupyter notebooks and python scripts. Maybe you can either get rid of the notebooks, or have the notebooks import the python scripts.

gabriele-ferrero commented 1 month ago

Notebook were implemented for easyness of use and then have been moved in another folder. I'll check the dependencies and make it work as I have enough time also to test it.
Working code >> easy to use code

RemDelaporteMathurin commented 1 month ago

Maybe the notebooks are not needed at all since it's just duplicated code (or an attempt at... see #15 )

Notebooks can also import python scripts which would get rid of this issue