Closed RemDelaporteMathurin closed 1 month ago
Thanks for making this great repo available @gabriele-ferrero !
Just a few questions:
Backwards compatibility may not be an issue (or less) for COMSOL, but for example in FESTIM, using t_stop and stepsize_stop_max will be deprecated in future releases of FESTIM in favour of max_stepsize : https://github.com/gabriele-ferrero/Titans_TT_codecomparison/blob/6ada184f85899c0793af63c8632d078d1e3703b8/Festim%20models/TDS_Tungsten.py#L80-L81
t_stop
stepsize_stop_max
max_stepsize
Therefore the scripts shown here may not work with say FESTIM 1.5. Could you add installation instructions in the README? Or maybe a conda environment file?
Same question for MHIMS even though the scripts are not released here.
Thanks for making this great repo available @gabriele-ferrero !
Just a few questions:
Backwards compatibility may not be an issue (or less) for COMSOL, but for example in FESTIM, using
t_stop
andstepsize_stop_max
will be deprecated in future releases of FESTIM in favour ofmax_stepsize
: https://github.com/gabriele-ferrero/Titans_TT_codecomparison/blob/6ada184f85899c0793af63c8632d078d1e3703b8/Festim%20models/TDS_Tungsten.py#L80-L81Therefore the scripts shown here may not work with say FESTIM 1.5. Could you add installation instructions in the README? Or maybe a conda environment file?
Same question for MHIMS even though the scripts are not released here.