Hammer gestures not working on Firefox OS

gabrielecirulli / 2048

The source code for 2048

https://play2048.co

MIT License

12.2k stars 16.99k forks source link

Hammer gestures not working on Firefox OS #18

Open soapdog opened 10 years ago

soapdog commented 10 years ago

Hi Gabrielle,

Fantastic and addictive game, congratulations! I decided to port it to Firefox OS and most of the things worked perfectly out of the box. The major issue was that Hammer gestures were not working so I reimplemented the swipe gestures using touch events. I also tweaked the UI to better fit the small 480x320 screen of Firefox OS devices.

Do you want a pull request for the touch events?

Cheers PS: The game is awaiting review in the Firefox Marketplace right now.

gabrielecirulli commented 10 years ago

Hammer was replaced with custom code to handle gestures in another PR. Do gestures work on Firefox OS now?

soapdog commented 10 years ago

I will check the code you have now and compare it with mine. I will post back here as soon as I have the info.

akien-mga commented 8 years ago

Hi @soapdog, sorry to hijack this issue but issues are not activated on your fork. Two questions:

Has this issue been solved in the meantime? If so it could likely be closed.
It would be nice to see the Firefox OS version in your fork synced with upstream, there has been quite a few new commits since 2014.

soapdog commented 8 years ago

Hi @akien-mga,

I will try the current master version. If it works, I will replace my routines with the current ones. Thanks a lot for pointing me to it. It has been a long time since I last touched this code, sorry for the delay.

Ciao!