gabrielecirulli / hn-special

A modern theme for Hacker News, with some added niceties.
MIT License
331 stars 71 forks source link

Unable to reply #106

Closed abrkn closed 8 months ago

abrkn commented 8 years ago

Steps to reproduce this issue

  1. Go to the comments for post, such as https://news.ycombinator.com/item?id=12297530
  2. Click "Reply" on a comment, such as https://news.ycombinator.com/reply?id=12297924&goto=item%3Fid%3D12297530%2312297924

    Expected result

Loaded page with comment box

Actual result

Blank page

visual_theme.js:206 Uncaught TypeError: Cannot read property 'tagName' of undefined
(anonymous function) @ visual_theme.js:206
(anonymous function) @ visual_theme.js:161
Settings.runModule @ settings.js:86
(anonymous function) @ settings.js:63
(anonymous function) @ settings.js:62

Notes and screenshots

Fails to load

PxlBuzzard commented 7 years ago

The particular comment you linked to seems to be handled gracefully now (screenshot below). I can't replicate it elsewhere. My guess, based on your linked comment, is that Hacker News itself had a bug when replying to a comment marked as [dupe].

image

inverse commented 1 year ago

Seeing this issue again

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'getElementsByClassName')
    at Object.callback (visual_theme.js:88:39)
    at Settings.runModule (settings.js:72:46)
    at settings.js:49:14
    at Array.forEach (<anonymous>)
    at HTMLDocument.<anonymous> (settings.js:48:24)
    at _.load (utility.js:16:16)
    at settings.js:45:7
    at utility.js:38:58

Example: https://news.ycombinator.com/item?id=33150086 commenting on any of these.

e.g. https://news.ycombinator.com/reply?id=33150819&goto=item%3Fid%3D33150086%2333150819

The OP original URL also exhibits this behaviour.

pratnala commented 8 months ago

I am seeing the same issue as @inverse. Happens on every page and every comment. Replying is completely broken.

inverse commented 8 months ago

@pratnala PR'd a fix :crossed_fingers:

inverse commented 7 months ago

Is it published? I'm unable to find it in Chrome store