Run syntax checker during travis build

gabrielfalcao / lettuce

Behavior-driven-development tool for python, inspired by Cucumber for Ruby ⛺

http://lettuce.it

GNU General Public License v3.0

1.27k stars 323 forks source link

Run syntax checker during travis build #544

Open brarcher opened 7 years ago

brarcher commented 7 years ago

In addition to running unit tests, these additional checks ensure that certain failures will not make it into the code base unintentionally.

brarcher commented 7 years ago

The pyflakes tool has been useful for me on various python project, so perhaps it may be useful here.

There were only three minor warnings from pyflakes. Two of them are fixed in this pull request. The last I have not resolved, as I am not as familiar enough with the code. If running pyflakes is valuable, is the following issue something that could be resolved or is it a false positive:

lettuce/django/steps/models.py:260: import 'step' from line 19 shadowed by loop variable

nikolas commented 7 years ago

great work - i recommend using flake8 which includes pyflakes, among other checks.