search

gabrielflorit / gulp-smoosher

Inline css and js links with file contents
MIT License
35 stars 6 forks source link

New option ignoreFilesNotFound #18

Closed lneves12 closed 8 years ago

lneves12 commented 8 years ago

Added a new option 'ignoreNotFoundFiles' so the plugin can keep going even if it find a nonexistent file

gabrielflorit commented 8 years ago

Hi @lneves12, this looks good, thanks for the addition. I'll take a closer look in the morning, will merge soon.

gabrielflorit commented 8 years ago

This is good - thanks for adding tests and documentation, much appreciated!

lneves12 commented 8 years ago

Thanks for the fast merge :+1: :) I corrected a small detail caused by my refactoring in this commit https://github.com/lneves12/gulp-smoosher/commit/0886c878db1d462bb4cbc2e9f4d48b941b05b822 - It doesn't have impact but you can add it in a future release if you want!

gabrielflorit commented 8 years ago

Hmm, it seems there's a mix of

callback(error)

and

return callback(error)

throughout the code, this is before your work. I wonder what's the right approach.

lneves12 commented 8 years ago

I guess 'return callback(error)' would be more correct when we have errors to avoid mistakes, so it doesn't try to execute the rest of the function.