search

gabrielflorit / gulp-smoosher

Inline css and js links with file contents
MIT License
35 stars 6 forks source link

Can't use it with jade. #5

Closed Spica2 closed 10 years ago

Spica2 commented 10 years ago

Can't use it with jade. Jade renders comments different as required (missing a blank before dashes).

gabrielflorit commented 10 years ago

Could you provide an example?

Spica2 commented 10 years ago

In jade comments are done like this

//smoosh with space at the end will output <!--smoosh -->

// smoosh with space after slashes becomes <!-- smoosh-->

// smoosh with both spaces will fail in jade. So in no case your requestet string <!-- smoosh --> for replacement is hit. A tolarant query or a custom replacement tag would be fine. At the moment I just have to hack the plugin, but thats not sustainable.

gabrielflorit commented 10 years ago

Oh, I see - so you're saying that there is no way to make a jade template output the following:

<!-- smoosh -->

Interesting. I suppose I could always modify the regex. Give me a few.

gabrielflorit commented 10 years ago

Let me know if you have any further issues.

Spica2 commented 10 years ago

Thanx. Have it already working with 0.0.5