search

gabrielflorit / gulp-smoosher

Inline css and js links with file contents
MIT License
35 stars 6 forks source link

Why not just inline local resources by default? #7

Closed indolering closed 9 years ago

indolering commented 10 years ago

I want to inline all local resources, so why don't you just check for "http" or "//" at the beginning of the src/href entries?

gabrielflorit commented 10 years ago

I don't understand. Can you provide a detailed example of what you'd like?

indolering commented 10 years ago

Get rid of the declarations by default and add checking for local vs. remote scripts/links.

gabrielflorit commented 10 years ago

Ah, I see. That would certainly fit my needs, but it's a breaking change, and a rather big one. Let me think about it.

indolering commented 10 years ago

Ah, I see. That would certainly fit my needs, but it's a breaking change, and a rather big one. Let me think about it.

Breaking? I'm not saying <!-- smoosh --> declarations are a bad thing and I'm totally against getting rid of them entirely! You should check the page for smoosh declarations and proceed from there.

Although, I would like to see <!-- !smoosh --> support!

gabrielflorit commented 9 years ago

closed, #9 provides more detail