search

gabrielflorit / script-8.github.io

A JavaScript-based (React + Redux) fantasy computer for making, sharing, and playing tiny retro-looking games.
https://script-8.github.io/
MIT License
646 stars 35 forks source link

Add key pressed and released properties on input #204

Closed Kethku closed 5 years ago

Kethku commented 5 years ago

This adds tracking of the previous input state and adds key pressed and released properties to the input object.

This currently also adds mouseDownPressed and mouseDownReleased properties. I left it as is because its more elegant, the properties aren't documented, and they are potentially useful, but I could add an if statement to modify the variable name if you would like.

I'm not super happy with the documentation change either... I think the paragraph is getting long enough that it might be useful to break it up into multiple lines, but I didn't spend the time to see how the documentation ui was created. I can do that work if you would like though.

gabrielflorit commented 5 years ago

This is great. I would prefer if we didn't add any more mousedown properties. It might be useful in the future, but I don't see it right now. Would you be able to do that?

The docs do have to change, you're right. I can work on that after the PR is merged, no worries.

Thanks again - your solution is much more elegant than what I had in mind. Less code = win!

Kethku commented 5 years ago

Totally. I will filter out the mouse properties and update the PR shortly

Get Outlook for iOShttps://aka.ms/o0ukef

From: Gabriel Florit notifications@github.com Sent: Tuesday, February 19, 2019 6:29:28 PM To: script-8/script-8.github.io Cc: Keith Simmons; Author Subject: Re: [script-8/script-8.github.io] Add key pressed and released properties on input (#204)

This is great. I would prefer if we didn't add any more mousedown properties. It might be useful in the future, but I don't see it right now. Would you be able to do that?

The docs do have to change, you're right. I can work on that after the PR is merged, no worries.

Thanks again - your solution is much more elegant than what I had in mind. Less code = win!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/script-8/script-8.github.io/pull/204#issuecomment-465394745, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADK2791oAB2ErVBhSV6xOTNHqctKcVHXks5vPLMIgaJpZM4bEPPZ.