gabrielguerrero / ngrx-traits

NGRX Traits is a library to help you compose and reuse state logic in your angular app. There is two versions, @ngrx-traits/signals supports ngrx-signals, and @ngrx-traits/{core, common} supports ngrx.
MIT License
44 stars 3 forks source link

fix(example-app): Remove dependencies to deprecated @angular/flex-layout #37

Closed DelBiss closed 3 months ago

DelBiss commented 4 months ago

Usage of @angular/flex-layout was creating Conflicting peer dependency when running npm install Removing this dependency fix that.

When removing it's usage from example-app to be able to build, no other change have been made to the html. It's possible it may not represent the intended output, but the librairy look to be working appropriatly.

Since I'm not the creator, it's hard to access, but would be ready to make the necessary change.

gabrielguerrero commented 3 months ago

@DelBiss Thanks again for your contribution, this is now merge in the beta branch , I could not merge it directly because there were some conflicts so I had to rebase your branch from a copy I did of it

gabrielguerrero commented 3 months ago

As mentioned closing because this was merged to beta branch after a rebase in a copy of this branch