search

gabrieljackson / mattermost-plugin-wrangler

Manage Mattermost Messages Masterfully!
Apache License 2.0
49 stars 12 forks source link

Moved post does not include uploaded files or copy-pasted images #53

Closed mickmister closed 4 years ago

mickmister commented 4 years ago

Any uploaded files such as images or audio are not present in the resulting post of moving a message. I think this can be fixed by pointing each file object to the respective new post that it was originally associated with.

mickmister commented 4 years ago

I'm not entirely sure my proposed solution is possible, as it doesn't make much sense to be able to change the post the file is associated with. So each file may need to be re-processed as a new file.

gabrieljackson commented 4 years ago

Hey @mickmister, thank you for the report. I actually recently investigated this, but hadn't gotten around to opening an issue yet.

Your second comment is correct. Wrangler, currently, does not remove file attachment data from the original post list when creating the new "moved" posts. Unfortunately, this doesn't matter as the create-post process silently ignores these files when creating a post. After talking to some Mattermost engineers, it definitely seems like Wrangler will need to manually re-upload files along with any new posts created. This is something I want to support, but in the short term I am going to document it at the very least.

Also, just as a small FYI, emoji reactions also cannot be directly copied when the new post is created. I will be documenting that as well.

gabrieljackson commented 4 years ago

The process for re-uploading file attachments was pretty straight-forward so the plugin now supports "moving" files along with their messages.

This will be included in the next release cut.