search

gabrielmaldi / chrome-lock-tab

Chrome extension to prevent a tab from being closed accidentally
https://chrome.google.com/webstore/detail/lock-tab/nhbdiieigbgalknjplfpgmjnpbnkchnb
16 stars 1 forks source link

Layout of Lock Warning #3

Closed hellwegdigital closed 1 year ago

hellwegdigital commented 1 year ago

Thank you for the app.

Would it be possible to change the lock alert layout? Maybe with a custom text and colored with an exclamation mark?

gabrielmaldi commented 1 year ago

Thanks for the suggestion, @hellwegdigital!

I'd love to be able to present a custom dialog or at least change the text; unfortunately, Lock Tab uses the beforeunload browser event:

https://github.com/gabrielmaldi/chrome-lock-tab/blob/4c7ee39bb705ca4eaca0b5276c7f814b77672de7/src/script.js#L37-L49

Browsers are very restrictive in what they allow you to do in that handler, you can't even set a custom text like it used to be possible (this is to avoid a security concern — as you can see in the code, Lock Tab sets the text anyway in case this behavior is reversed in the future, but I wouldn't count on it at all).

A custom Lock Tab dialog is also out of the question because we have no way of knowing when the tab is about to be closed (besides beforeunload which is not designed to alter the page in any way).

So sadly I think we have no room to change anything regarding this.

Thanks anyway for your contribution!