gabrielmoreira / riot-router

Riot Router - A simple routing solution for Riot
MIT License
77 stars 13 forks source link

query parameter are not supported #24

Open sammeel opened 8 years ago

sammeel commented 8 years ago

Hey

When we use query parameters and we don't have a trailing slash to the path, we will get a page not found.

I've been able to reproduce this in the example on http://gabrielmoreira.github.io/riot-router/examples/example-01.html

When you would go to the url http://gabrielmoreira.github.io/riot-router/examples/example-01.html#/about?something then you get a page not found.

but this url will work (with trailing slash): http://gabrielmoreira.github.io/riot-router/examples/example-01.html#/about/?something

Could you have a look at this? Thanks in advance.

gabrielmoreira commented 8 years ago

Hi Sammeel , i'm on vacation. When i return i will look it. Em 05/04/2016 13:59, "sammeel" notifications@github.com escreveu:

Hey

When we use query parameters and we don't have a trailing slash to the path, we will get a page not found.

I've been able to reproduce this in the example on http://gabrielmoreira.github.io/riot-router/examples/example-01.html

When you would go to the url http://gabrielmoreira.github.io/riot-router/examples/example-01.html#/about?something then you get a page not found.

but this url will work (with trailing slash): http://gabrielmoreira.github.io/riot-router/examples/example-01.html#/about/?something

Could you have a look at this? Thanks in advance.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/gabrielmoreira/riot-router/issues/24