search

gabrielpjordao / pyfunct

A small framework to organize python functional web tests
24 stars 9 forks source link

Adds 'fill' and 'clear' actions #4

Closed vicentealencar closed 11 years ago

gabrielpjordao commented 11 years ago

Nice Vicente!

I think we could add the clear method to the base browser driver, in (https://github.com/gabrielpjordao/pyfunct/blob/master/pyfunct/browsers.py#L33) and raise a NotImplementedError.

Also, please add a test for it here: https://github.com/gabrielpjordao/pyfunct/blob/master/tests/contrib/test_splinter_driver.py#L8

Thanks,

gabrielpjordao commented 11 years ago

Also, when updating it, please change _handle_empty_element_action to @element_action decorator, since the other actions were changed to it too.

vicentealencar commented 11 years ago

I have made the changes you suggested. Let me know if you would like me to add anything!

gabrielpjordao commented 11 years ago

Great. Thank you!