search

gabrielrcouto / php-gui

Extensionless PHP Graphic User Interface library
2.24k stars 175 forks source link

New Components Implemented #113

Closed everton3x closed 7 years ago

everton3x commented 7 years ago

Implementation to:

TCalendar -> Calendar TDateEdit -> InputDate TTimeEdit -> InputTime TSpinEdit/TFloatSpinEdit -> InputNumber TEdit -> InputPassword

reisraff commented 7 years ago

Hey @everton3x I have one advice for you.

keep your branch master updated with the gabrielrcouto/master, and do your changes in separated branchs, that way you will avoid merge conflicts.

everton3x commented 7 years ago

Tanks @reisraff.

Actually, I'm a beginner in the contributions of GitHub. I only used it to store some of my projects.

If you have any material beyond the basics about Git I appreciate the suggestion. If it is in Portuguese, thank you, because my English is not very good (God save the Google Translate) What I read until today has always been rather superficial.

alrik11es commented 7 years ago

What happened to this PR? (Seems really interesting) may I help with something?

reisraff commented 7 years ago

This PR has conflicts with the HEAD of master, that means @everton3x should rebase your code with the last update of gabrielrcouto/master, that way we can accept that, and merge ;)

reisraff commented 7 years ago

@everton3x can you please update this PR?

everton3x commented 7 years ago

From what I've seen, the problem is the size of some lines.

This week I'm pretty busy, but next week I can do it without problems.

everton3x commented 7 years ago

After a hard work correcting the source code to fit the PSR2, everything is ready. I'm still struggling to fit into PSR2.

reisraff commented 7 years ago

@everton3x okay, nice work, but still have some notes to review.

https://github.com/gabrielrcouto/php-gui/pull/113#discussion_r109942872 https://github.com/gabrielrcouto/php-gui/pull/113#discussion_r109944049 https://github.com/gabrielrcouto/php-gui/pull/113#discussion_r109944027 https://github.com/gabrielrcouto/php-gui/pull/113#discussion_r109943277 https://github.com/gabrielrcouto/php-gui/pull/113#discussion_r109943078

reisraff commented 7 years ago

@everton3x do you get to finish this? is missing just some stuff... Or can I fork it and finish?

everton3x commented 7 years ago

@reisraff I started working on it a few days ago, but I had to stop work because of the professional priorities that have come up. If you have the will and availability, feel free to make a fork and finish. Thank you very much.

reisraff commented 7 years ago

Closing, continue with #117