search

gabrielsroka / gabrielsroka.github.io

My website, including rockstar: Export Okta Users, Groups, etc. to CSV. Show SAML assertion.
https://gabrielsroka.github.io/
MIT License
89 stars 37 forks source link

update sign on policy export #60

Closed pbish-prh closed 1 year ago

pbish-prh commented 1 year ago

Modified the app sign on policy export to include all of the policy data in a more digestible format. Attached a rough PS script as an example, to parse the data from the export into a usable csv. OktaAppCleanup.zip

gabrielsroka commented 1 year ago

thanks for your PR, i'm not going to use it.

pbish-prh commented 1 year ago

Okay!

Do you mind if I ask why? I know this is my first attempt at contributing to an open source project, but the current function exports nothing but the word “Priority” in the policies column, due to Okta’s weird table design. With this small change, my peers were able to export the data that they needed. I don’t expect an answer, but I’m new to open source contributions I would very much appreciate knowing what I can do to make my contributions more meaningful.

Thanks!

Patrick

gabrielsroka commented 1 year ago

here's a powershell version

https://github.com/gabrielsroka/OktaAPI.psm1/blob/master/OktaPrivateAPI.ps1

This calls a private API that can change so I don't want to write too much code against it because it will be brittle.

Also it's usually best to open an issue and coordinate with the repo owner before submitting a PR.

pbish-prh commented 1 year ago

Thank you for the information and the advice! I meant no offence.

Patrick

From: Gabriel Sroka @.> Sent: Wednesday, June 28, 2023 6:33 PM To: gabrielsroka/gabrielsroka.github.io @.> Cc: Bish, Patrick @.>; Author @.> Subject: Re: [gabrielsroka/gabrielsroka.github.io] update sign on policy export (PR #60)

CAUTION: This email originated from outside of Penguin Random House. Please be extra cautious when opening file attachments or clicking on links.

here's a powershell version

https://github.com/gabrielsroka/OktaAPI.psm1/blob/master/OktaPrivateAPI.ps1https://github.com/gabrielsroka/OktaAPI.psm1/blob/master/OktaPrivateAPI.ps1

This calls a private API that can change so I don't want to write too much code against it because it will be brittle.

Also it's usually best to open an issue and coordinate with the repo owner before submitting a PR.

— Reply to this email directly, view it on GitHubhttps://github.com/gabrielsroka/gabrielsroka.github.io/pull/60#issuecomment-1612200883, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7S4NXZIANP5DZEM7DWNMN3XNSWIJANCNFSM6AAAAAAZXVEPKU. You are receiving this because you authored the thread.Message ID: @.**@.>>

gabrielsroka commented 1 year ago

No offense taken.