[Feat]: Implement Header Navigation Background Color Based on Theme for Improved Scroll Visibility

gabrysia694 / Gym-Junkies

This website allows users to add their favorite exercises with a video demonstration and step-by-step instructions on how to perform the exercise. We would greatly appreciate it if you could give a star to our project :star:

https://gymjunkies.netlify.app

MIT License

76 stars 118 forks source link

[Feat]: Implement Header Navigation Background Color Based on Theme for Improved Scroll Visibility #258

Open kuntal0901 opened 11 months ago

kuntal0901 commented 11 months ago

What feature?

I have an idea you can keep the header nav to be set with a background color white and black based on theme. So that it doesn't look transparent because of padding when scrolled above.

Add screenshots

Old Preview

New Preview with background added to header.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

github-actions[bot] commented 11 months ago

Congratulations, @kuntal0901! 🎉 Thank you for creating your first issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!

Anirud2002 commented 11 months ago

I pulled up a PR which implements this feature. Thanks for the feature request!