search

gabstopper / smc-python

Forcepoint Security Management Center python library:(Moved to official Forcepoint repo)
https://github.com/Forcepoint/fp-NGFW-SMC-python
Apache License 2.0
29 stars 13 forks source link

SMC_CLIENT_CERT, possible misunderstanding #65

Open sebbbastien opened 5 years ago

sebbbastien commented 5 years ago

Hi David,

I hesitated a lot before creating this issue, but I think it makes a real misunderstanding.

The SMC_CLIENT_CERT option in the.smcrc file suggests that it is a certificate to be presented to the CMS, a mutual ssl authentication in short.

Wouldn't a SMC_CA or SMC_SERVER_CA type name be better?

If you agree, I would be happy to take the point and try to submit a PR on this subject in the upcoming weeks.

Best regards,

gabstopper commented 5 years ago

Hi Sebastian, I understand. If you want to put a pull request in that would be great! Or if you file it at the github site, I can implement. I will still support the old method but hide it going forward - I think this makes sense.

David

On Fri, Jul 26, 2019 at 4:59 AM Sébastien notifications@github.com wrote:

Hi David,

I hesitated a lot before creating this issue, but I think it makes a real misunderstanding.

The SMC_CLIENT_CERT option in the.smcrc file suggests that it is a certificate to be presented to the CMS, a mutual ssl authentication in short.

Wouldn't a SMC_CA or SMC_SERVER_CA type name be better?

If you agree, I would be happy to take the point and try to submit a PR on this subject in the upcoming weeks.

Best regards,

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gabstopper/smc-python/issues/65?email_source=notifications&email_token=ADRABVO4TUPVVID2SWDQMSDQBLDHDA5CNFSM4IHCLPW2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HBVVEJA, or mute the thread https://github.com/notifications/unsubscribe-auth/ADRABVMBPOAVU7OTWHTQ6I3QBLDHDANCNFSM4IHCLPWQ .