search

gabyang / pe

0 stars 0 forks source link

Long names are not displayed fully #4

Open gabyang opened 1 year ago

gabyang commented 1 year ago

Bug Description

Screenshots / Videos

image.png

nus-pe-bot commented 1 year ago

Team's Response

Hi, this is intended behaviour. Here is our team's rationale:

  1. A list view is supposed to provide an OVERVIEW of all customers, or the list would be very long if a customer has a very long name, it would expand and make it hard to see the other customer's on the list. This suggestion would be bad for the user experience.
  2. If you want to see the FULL details of the customer, including the name - you can view it on the customer pane (just like this screenshot shows) where the NAME is not truncated off. Hence, the user still can read long, full names.
  3. The index on the list is always properly displayed in the list view, even with long names. The user should have no problem using the opencus command to view their details, such as their full name.

Given that there are merits to having name truncation for very long names in the list, and the user still has an option to view full names, we believe this is not a problem.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I agree with your merits. This is a nitpicky bug in my opinion. To me, a bug does not solely depend on the merits. The existence of a bug indicates that there is room for problems to occur. Here are some problems I foresee:

1) User is unable to distinguish similar long names that are truncated. Yes, given that there is a way to view the full name of a person by selecting the index, it still causes a minor inconvenience for the user to work out extra commands in the CLI in order to really find the name that they want. For example, User cannot remember exactly the very long names and have to enter multiple find commands to find both names. Assume worse case that all words are different by a letter eg "pablo" and "pabloh". Hence, the severity is low.

image.png

2) Assuming User decides not to use the CLI to find names. Users that saved similar long names in indexes that are far away from each other (for example, index 1 and index 50) will take pains to scroll up or down vigorously to see

In any case, I still see minor inconveniences in these scenarios. Hence a low severity bug.