search

gabyang / pe

0 stars 0 forks source link

Advance editting of the json file may lead to complete loss of data #9

Open gabyang opened 1 year ago

gabyang commented 1 year ago

Advanced user tried to edit the json file in particular the tag is set to empty string image.png

nus-se-script commented 1 year ago

Team's Response

This is the expected and correct behavior. Tags cannot be empty.

Below is a relevant extract of our UG that clearly dictates what will happen if the user corrupts their data file.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This in my opinion is a nitpicky bug.

Yes, what your UG says may be true, but taking into account a user who just onboarded your platform. It is not clear to him that an empty tag is an invalid format.

A reasonable scenario to accept would be this: The Advanced User wanted to delete a tag, so he deleted the string inside of his tag array, but left the quotations mark in. The User does not know that an "empty string" is an invalid format because he notices that he could add customers without specifying a tag. Thus, he misunderstands that this is a valid format.

Should you want to prevent these scenarios, it would be more prudent for your UG to say, "Caution: We do not recommend that a user edits the data file directly for fear of loss of data..." instead of "Caution: if your changes to the data file makes its format invalid ..."

Stating the worst-case scenario of what will happen is not the same as stating what the user should do to prevent the happening of the worst-case scenario. Because of this, I forsee that this can cause minor inconveniences or frustration due to the loss of data without knowing what an "invalid format" means, and thus, a low severity bug.