search

gabyx / ApproxMVBB

Fast algorithms to compute an approximation of the minimal volume oriented bounding box of a point cloud in 3D.
Mozilla Public License 2.0
441 stars 93 forks source link

Fix broken Visual Studio build #15

Closed Maghoumi closed 7 years ago

Maghoumi commented 7 years ago

Hello Gabriel, it's me again : ) When I tried building with VS 2015, I noticed there were a couple of minor issues preventing the build. This PR fixes those issues. I can confirm that the project builds fine under VS 2015 and the example works. Similar to before, the tests don't build under VS.

Hope this helps. Cheers

gabyx commented 7 years ago

Thanks, could you explain why you commented out in EstimateDiameter. ?? This might break somethings unexpectedly

Maghoumi commented 7 years ago

No problem. In one of your previous commits, you have commented out the implementation of the function _CountPointsInSpheres. Also the code that's calling that function is inside an if(0) statement, and therefore is never called. My guess is that GCC completely ignores if(0) statement and does not even compile them. On VS however, the compiler was looking for the implementation of _CountPointsInSpheres. Since it couldn't find it, it was generating linker errors. I commented that line out and now everything compiles. To be honest, I don't know what the function of _CountPointsInSpheres is and why you've commented it out! : )

gabyx commented 7 years ago

ah perfect! will look through it. thanks for the contribution!

Von meinem iPhone gesendet

Am 14.10.2016 um 16:15 schrieb Mehran Maghoumi notifications@github.com:

No problem. In one of your previous commits, you have commented out the implementation of the function _CountPointsInSpheres. Also the code that's calling that function is inside an if(0) statement, and therefore is never called. My guess is that GCC completely ignores if(0) statement and does not even compile them. On VS however, the compiler was looking for the implementation of _CountPointsInSpheres. Since it couldn't find it, it was generating linker errors. I commented that line out and now everything compiles. To be honest, I don't know what the function of _CountPointsInSpheres is and why you've commented it out! : )

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Maghoumi commented 7 years ago

The function time called in that file required that header. I think the MSVC include chain did not include a header in which time was included. Adding #include<time.h> solved those issues.

gabyx commented 7 years ago

Sorry, of course, I searched for it, but did not find it sorry, :-)