search

gabyx / ApproxMVBB

Fast algorithms to compute an approximation of the minimal volume oriented bounding box of a point cloud in 3D.
Mozilla Public License 2.0
441 stars 93 forks source link

VS2017 - definition of dllimport function not allowed errors #24

Open adam-hartshorne opened 6 years ago

adam-hartshorne commented 6 years ago

When building the library and various projects, I receive a number of #C2491 errors e.g. error C2491: 'ApproxMVBB::approximateMVBBGridSearch': definition of dllimport function not allowed

I believe it is this problem which is specific to Visual Studio compiler,

https://msdn.microsoft.com/en-us/library/62688esh.aspx

https://docs.microsoft.com/en-us/cpp/cpp/using-dllimport-and-dllexport-in-cpp-classes

gabyx commented 6 years ago

could you send me the output log :) thanks. then i can fix it

gabyx commented 6 years ago

or even better send me a PR :) eith the fix. because I have no windows here :)

adam-hartshorne commented 6 years ago

Find attached the output log. I am away this week, so I am not going to have a chance to properly look at a potential fix myself for the next few days.

AproxMVBB_vs2017_build_log.txt

gabyx commented 5 years ago

Could you test on the current master branch with VS 17 if the problem persists?