search

gabyx / ApproxMVBB

Fast algorithms to compute an approximation of the minimal volume oriented bounding box of a point cloud in 3D.
Mozilla Public License 2.0
441 stars 93 forks source link

ApproxMVBB library version could not be determined!, HEAD-HASH-NOTFOUND #28

Closed thomas2108 closed 5 years ago

thomas2108 commented 5 years ago

Same in CMAKE 3.12.2 for Windows and Visual Studio 2017 (15.8.3)

Please help error

gabyx commented 5 years ago

Did you download the zip, file and tried to build from that? I think that might cause the issue, since there is no .git folder, hm... I should make a version file :-), and read from this if there is no ".git" folder

thomas2108 commented 5 years ago

Yes, I downloaded the Zip. Can i do something?

gabyx commented 5 years ago

Fork the repository instead, and build it, then it works. Meaning, clone it in git

thomas2108 commented 5 years ago

Done, have several issues:

AngleFunctions.hpp + MakeCoordinateSystem.hpp: M_PI undefined inserted 

#define _USE_MATH_DEFINES
#ifndef M_PI
#    define M_PI 3.14159265358979323846
#endif

before #include <cmath>

in xpfpa.h replaced # elif HAVE__CONTROLFP_S with # elif defined(HAVE__CONTROLFP_S)

ApproxMVBB 32Bit Debug now builds, others still error….continue later

gabyx commented 5 years ago

Can you make a PR when you manage to compile it with VS 17, thx!

thomas2108 commented 5 years ago

I managed to build ApproxMVBB with VS17. VS2017 contains native CMAKE support and builds the lib directly now. Have .dll file and .lib file. But I'm not able to build example/approxMVBB . Linker is missing the library. I'm no CMAKE expert, don't know what to do. Can you assist ? unbenannt

gabyx commented 5 years ago

Working on a solution for VS 15/17. I dont have 17, but should work as well

gabyx commented 5 years ago

Please try the branch: msvc-compatibility It seems to compile under VS 15 so far. cmake -G "Visual Studio 14 2015 Win64" -DApproxMVBB_XML_SUPPORT=OFF -DApproxMVBB_KDTREE_SUPPORT=OFF <pathToCode>

gabyx commented 5 years ago

Try the current master branch if it builds in VS 17

adam-hartshorne commented 5 years ago

I have problems using cmake to build a solution file. First I get the following error,

ApproxMVBB library version could not be determined!

And can't get around that.

Second, the Find PugiXML_DIR is rather odd. Rather than wanting the base location or the location of the lib file, it wants the location of the _source_dir/CMakeFiles/Export/lib/cmakepugixml/ and for the compiled library to be in the Export/lib directory.

Third, why are we having to give the location of git.exe. Seems rather odd dependency.

gabyx commented 5 years ago

Ok, git is used for determining the version, I try to remove this need. When you installed PugiXML with cmake, the ApproxMVBB should find it, we do not provide script for finding pugixml since by default it is found correctly with the default finding procedure in cmake since pugixml also supports this. I update the docs so far, and pugixml is now by default disabled (ApproxMVBB_XML_SUPPORT="OFF") on the master branch.

gabyx commented 5 years ago

As a remedy for now, clone the repo with git. Dont use the zip file...

adam-hartshorne commented 5 years ago

I am cloning with git.

On Thu, Sep 20, 2018 at 8:29 AM Gabriel Nützi notifications@github.com wrote:

As a remedy for now, clone the repo with git. Dont use the zip file...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/gabyx/ApproxMVBB/issues/28#issuecomment-423071759, or mute the thread https://github.com/notifications/unsubscribe-auth/ATKVNGoJseQ8SrfKLiqSTce4iPSYlGaQks5uc0PlgaJpZM4Wnb0d .

gabyx commented 5 years ago

I updated, Git should now no more be needed, as long as you delete the .git folder: then the version is read from the version file VERSION.