search

gabyx / Githooks

🦎 Githooks: per-repo and shared Git hooks with version control and auto update. [✩Star] if you're using it!
MIT License
102 stars 4 forks source link

Install script fixes #146

Closed mruz closed 4 months ago

mruz commented 4 months ago

On openSUSE I have just linux in $OSTYPE and filenames have macos in the name https://github.com/gabyx/Githooks/releases/tag/v2.8.0

gabyx commented 4 months ago

This is good to go, some small change needed since I want to leave darwin in there, because its not necessary to change it. might be to brittle.

mruz commented 4 months ago

For darwin I'm getting: image (8)

mruz commented 4 months ago 
$ curl --silent --location https://api.github.com/repos/gabyx/Githooks/releases/tags/v2.8.0 \
    | jq --raw-output ".assets[] | select( (.name | contains(\"darwin\")) and (.name | contains(\"arm64\")) ) | .browser_download_url"

$ curl --silent --location https://api.github.com/repos/gabyx/Githooks/releases/tags/v2.8.0 \
    | jq --raw-output ".assets[] | select( (.name | contains(\"macos\")) and (.name | contains(\"arm64\")) ) | .browser_download_url"
https://github.com/gabyx/Githooks/releases/download/v2.8.0/githooks-2.8.0-macos.arm64.tar.gz
gabyx commented 4 months ago

Ah, ok thanks for the hint! But could you leave darwin in the paltform script and make an darwin to macos overwrite in the install.sh script. That might be better!

Thanks for the patch.

gabyx commented 4 months ago

@mruz : I changed it, will merge in a second.