gabyx / Githooks

🦎 Githooks: per-repo and shared Git hooks with version control and auto update. [✩Star] if you're using it!
MIT License
102 stars 4 forks source link

v3 Does not install; Arch Linux #167

Closed nf-brentsaner closed 2 months ago

nf-brentsaner commented 2 months ago
$ ./install.sh 
! ERROR: Linux Distro '/etc/os-release' not supported currently: NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://gitlab.archlinux.org/groups/archlinux/-/issues"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

Arch uses a rolling release. Is there a particular reason get_platform_os() is even called in the installer other than to determine the OS? I don't see the OS release/version itself used anywhere for Linux.

How can I install v3, being that Arch has no version (and outright fails the if/else in the installer)?

Note that this same issue would present for other users of rolling distros (Fedora Rawhide, SuSE Tumbleweed, etc.).

gabyx commented 2 months ago

Thats a good point. I gonna fix it. by adjusting for arch. Thanks for the report. You can just download the cli executable on the release page and start it exactly the same as you would.

cli installer ...

gabyx commented 2 months ago

@: Can you check that it works on this branch:

168 by doing

curl -sL https://github.com/gabyx/Githooks/blob/d5cefdb1902a807c159ee64de06eeb5c90e02dad/scripts/install.sh ...

instead

gabyx commented 2 months ago

Fixed in: #168

nf-brentsaner commented 2 months ago

Will check/confirm in about an hour or so! Apologies for the delay. Thanks for the prompt response/reaction!

nf-brentsaner commented 2 months ago

And confirmed on Arch! Thanks again!