Refactor: Move input validation

gabzim / circle-to-polygon

Receives a Coordinate, a Radius and a Number of edges and aproximates a circle by creating a polygon that fills its area

ISC License

113 stars 29 forks source link

Refactor: Move input validation #19

Closed johachi closed 4 years ago

johachi commented 4 years ago

This PR extracted input validation functions since the main file (index.js) was starting to get too big.

johachi commented 4 years ago

I noticed that some of my PR's risked of growing in size if I don't break them down in meaningful small PR's that are more easy to check.

johachi commented 4 years ago

@gabzim I realized that some of the branches I'm working on was becoming quite big, especially when moving functions and tests around. (Look bigger than they are since moving stuff creates a lot of "noise".)

To not create mega PRs I thought it could be a good idea to create many but small and easy to comprehend PRs. Do you prefer this, or that I just do one big PR?