search

gabzim / circle-to-polygon

Receives a Coordinate, a Radius and a Number of edges and aproximates a circle by creating a polygon that fills its area
ISC License
113 stars 29 forks source link

Oval Polygon #34

Closed arzanardi closed 3 years ago

arzanardi commented 3 years ago

Hello, I put the polygon returned by the function on a map but at the end I got an oval shape Where can I be wrong?

See:

gabzim commented 3 years ago

Hi @arzanardi can you give me a code example to reproduce? (coords, edges, etc)

johachi commented 3 years ago

Hi @arzanardi !

Your image link seems to be broken. Could you please re-upload the image (you can upload images directly to the github comments. We also (as @gabzim said) need to know what coordinates you used together with the other parameters you sent.

arzanardi commented 3 years ago

Hi guys, You can ignore the case, I had inverted lat and lon.

Thank you so much for your attention.

gabzim commented 3 years ago

Excellent @arzanardi, good to know that inverting them can cause the issue. I'll keep that in mind if this comes back again.

chramos commented 2 years ago

I agree guys, the library is amazing and really helpful, but the api is a bit confusing. I spent lots of time to understand why I was getting oval Polygon

johachi commented 2 years ago

I agree guys, the library is amazing and really helpful, but the api is a bit confusing. I spent lots of time to understand why I was getting oval Polygon

Thank you for the feedback! Any suggestion on how we could make the documentation clearer?