How to build the apps?

[joe83]

how to build the apps with shadow-cljs? any instruction detail? thanks

[gacelita]

Hello!

For development builds, just starting the system should be enough for shadow-cljs to be running.

For a production build, just run npm install followed by lein uberjar. The project.clj defines a prep-task for compiling the clojurescript code and the SASS files:

However, I just tried with a cleanly cloned repo and it doesn't seem to work. You need to do this before running lein uberjar:

npm install babel-core
npm install babel-preset-env

This is obviously a bug and I will fix it ASAP.

Thanks!

[joe83]

got this error after

npm install babel-core npm install babel-preset-env lein uberjar

[joe83]

Finally make it working by add "src/cljs" in :uberjar profiles.

:uberjar [:datomic-pro :build-client {:source-paths ^:replace ["src/clj" "src/cljc" "src/cljs"] btw, after build. on browser I got almost 1366 js file downloaded. how to set the prep-task parameter to minimize the js become only 1 main.js?

[gacelita]

Glad you found the problem. shadow-cljs should be doing a minified compilation already, but I'm not home right now to check. See ventas-devtools.uberjar if you want to check. I'll gladly accept a PR :)

[gacelita]

I got home. So, I'm going to create a new alias for building the cljs, because using prep-tasks poses several problems:

• Including cljs source paths when in fact they aren't needed for the jar itself
• Including ventas-devtools and the cljs dependencies in the jar, when they shouldn't

Will update this task when it is done

[gacelita]

Changes pushed, deployed the snapshot. Now the command for building CLJS and SASS is lein compile-frontend. After that, you can call lein uberjar.

And yes, the shadow-cljs compilation for prod wasn't being done properly. That should work now too.

[joe83]

now the error

[gacelita]

Yes, I have noticed. Some deps problem. Will take a look tomorrow

El lun., 3 dic. 2018 0:27, joe83 notifications@github.com escribió:

now the error

[image: ventas2] https://user-images.githubusercontent.com/10484058/49346398-7ca4d400-f6c4-11e8-963d-b6d9be4b0e61.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/JoelSanchez/ventas/issues/33#issuecomment-443552524, or mute the thread https://github.com/notifications/unsubscribe-auth/AHpgMZsg1WENTpf8sBo-t38JiTOG8SEfks5u1GHygaJpZM4Y8vB0 .

[joe83]

seems you missed some dependency, because after I run

lein uberjar

then run

lein compile

the reader-error is gone.

but now the error change to

[gacelita]

@joe83 I did some changes to fix the dependencies. Should be working now

[gacelita]

And yes I saw that error too :)

[joe83]

@joe83 I did some changes to fix the dependencies. Should be working now

perfect.. thanks