gacopl / dvmkv2mp4

Convert any Dolby Vision/HDR10+ MKV to DV MP4 that runs on many devices
198 stars 36 forks source link

OSX: SRT subtitles don't mux because of chosen filename + Missing requirements #19

Closed tommytoch closed 1 year ago

tommytoch commented 1 year ago

Hi,

Using OSX 10.14.6

First of all, many thanks for creating this wonderful piece of software.

After demuxing your program creates files from "movie.mkv" named "movie DV-MP4.eng.srt" Under OSX Terminal this creates the issue that this subtitle won't be muxed in again in the final stage of the process. A simple solution would be to remove the space and use a dot. In other words: "movie DV-MP4.eng.srt" should become "movie.DV-MP4.eng.srt" This behaviour exists (I suppose) because OSX Terminal handles spaces in filenames in a different way compared to linux shell.

A few minor points:

Thanks for looking into this (if possible) and keep up the good work!

gacopl commented 1 year ago

hi please run with debug option and paste log output

tommytoch commented 1 year ago

Regretfully, I'm an idiot. I misunderstood the -s flag and thought it was enabled by default. I'm truly sorry for wasting your time.

I did however run into in issue when selecting languages. I specified -l eng and yet all subtitles and audio were converted.

I can easily use MP4box -rem to remove the tracks afterwards. So it's not really a problem for me.

However if you wish to check on this, I've attached a mediainfo of the original mkv and the log.

mediainfo.txt log.txt

gacopl commented 1 year ago

in debug mode you should get sub.extracts file please paste. -l works that if it not hits the lang it will keep all of them so maybe instead of eng try English or und,eng

Or its a bug in osx sed so you would probably need to brew install gsed and replace sed with gsed in the script