search

gacopl / dvmkv2mp4

Convert any Dolby Vision/HDR10+ MKV to DV MP4 that runs on many devices
198 stars 36 forks source link

Update base image to ubuntu 22.04 and dependencies #29

Closed scandinave closed 8 months ago

scandinave commented 1 year ago

Hi,

This PR updates the base image and dependencies used with the docker flow. I was not able to complete the conversion with the actual version.

This is the command i have run to test the conversion 

docker run -it -u $(id -u):$(id -g) --rm -v /<dvmkv2mp4_dir>/dvmkv2mp4:/usr/local/bin/dvmkv2mpa -v "<mkv_path>":/convert dvmkv2mp4 -s

I have just test on docker version. If you want, I can also test and update the readme for the native one.

gacopl commented 1 year ago

It will not work with certain devices, i admire you wanted to upgrade mp4box but unfortunately anything above 1.0.1 will not work on C8, C9 if i remember correctly. As only 1.0.1 created hacked file that TVs would read. v2 will work on CX and above but had issues with seeking on CX (slow skipping) It is also stated in README.

So i would propose do a dockerfile that works without changing the key components versions, and maybe keep this on the side ?

I think it probably did not work because of this

image

In any case it should perfectly work wiht mp4box 1.0.1 and fresh ffmpeg i think you went too far here there also might be some breaking changes in dovi v2