search

gacopl / dvmkv2mp4

Convert any Dolby Vision/HDR10+ MKV to DV MP4 that runs on many devices
198 stars 36 forks source link

Fix syntax for newer MP4Box version #52

Open SugaryHull opened 1 month ago

SugaryHull commented 1 month ago

1.0.1 doesn't build with FFmpeg 5.x and higher. I ran into this issue on Debian 12, which means it will only continue to be an issue going forward. Newer MP4Box versions expect the user to specify backwards compatibility for HDR10 now. I was able to get the latest git version working by hardcoding .hdr10 to the end of mp4string. This could theoretically be its own variable, but this is what works for me with UHD Blu-ray rips. As always, suggested changes are encouraged and appreciated!

-SugaryHull

gacopl commented 1 month ago

1.0.1 is stritly meant for ffmpeg4 try dev branch has newer mp4box and ffmpeg compatibility the reason was hack for older lg oleds

pt., 2 sie 2024, 20:23 użytkownik Alex @.***> napisał:

1.0.1 doesn't build with FFmpeg 5.x and higher. I ran into this issue on Debian 12, which means it will only continue to be an issue going forward. Newer MP4Box versions expect the user to specify backwards compatibility for HDR10 now. I was able to get the latest git version working by hardcoding .hdr10 to the end of mp4string. This could theoretically be its own variable, but this is what works for me with UHD Blu-ray rips. As always, suggested changes are encouraged and appreciated!

-SugaryHull

You can view, comment on, or merge this pull request online at:

https://github.com/gacopl/dvmkv2mp4/pull/52 Commit Summary

File Changes

(1 file https://github.com/gacopl/dvmkv2mp4/pull/52/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/gacopl/dvmkv2mp4/pull/52, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARMKIDFM47QFRX47AR5LMDZPPFDFAVCNFSM6AAAAABL5AGMISVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2DKNJTGI3DCMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>