search

gacsphere / capstone-project

batscan.vercel.app
MIT License
0 stars 0 forks source link

Feature/edit card #15

Closed gacsphere closed 1 year ago

gacsphere commented 1 year ago

The user can edit and save cards which will be appended to the cards list. In a future user story it should be possible to keep the cards in their place in the list. For now, the edited card switches its place to the top of the cards list.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
batscan ✅ Ready (Inspect) Visit Preview Nov 1, 2022 at 6:53PM (UTC)
AHen-C0de commented 1 year ago

Hey, that's an awesome solution to edit saved cards with the Form component!! :D I don't have much to add. Just one or two minor suggestions on var naming and code readability.

gacsphere commented 1 year ago

The code has been reviewed two times but didn't pass QA because of another problem in the form on top of the page (not the editCardForm, which was developed in this user story). So I made some additional changes mainly to the form and will go on with it in another user story, when I improve the UX for the forms.

The following has changed since the last code review: I set the preloaded values in the form from defaultValue to value and I don't show a default value anymore. This should lead the user to load the data with the new button "Lokale Daten laden" and the new function for this action "setLocalData", which reloads the actual local data. Now the local data can't be edited in the form anymore. I will work on the styling for that UX topic in another user story because now it seems like the user could edit the data. But the local data can be edited in the editCardForm.