search

gadenbuie / rsthemes

🔮 Full RStudio IDE and Syntax Themes
https://www.garrickadenbuie.com/project/rsthemes/
Other
593 stars 44 forks source link

Replace opacity with rgba in themes #52

Closed jmbuhr closed 3 years ago

jmbuhr commented 3 years ago

I noticed for a couple of themes where using them with vim-mode was harder, because the cursor was just a big block with no transparency. It seems that the opacity value doesn't do anything, so I replaced all hex-color values for the cursor in normal mode with rgba values. I defaulted to 0.5 opacity unless the theme already had another value.

I didn't do it for the base16 themes yet because they are so many I would probably write a script for that so I wanted to check with you first.

gadenbuie commented 3 years ago

Thanks! I decided to take a slightly different approach in #53. You can test it out by updating rsthemes, and reinstalling the themes (and maybe restarting RStudio).

remotes::install_github("gadenbuie/rsthemes@fix-cursor")
# restart R session
rsthemes::install_rsthemes()
# restart RStudio
rsthemes::try_rsthemes()
jmbuhr commented 3 years ago

Thanks! This looks like a more thorough solution.