search

gadenbuie / xaringanExtra

:ferris_wheel: A playground of enhancements and extensions for xaringan slides.
https://pkg.garrickadenbuie.com/xaringanExtra
Other
445 stars 36 forks source link

Support panelset chunk in quarto documents #193

Closed gadenbuie closed 7 months ago

gadenbuie commented 8 months ago

Improve support for panelset chunks in quarto documents:

  1. Treat [data-panelset="true"] the same as .panelset (by adding the class before initializing panelsets). Quarto takes the unknown paneset chunk option and keeps it as a data attribute, so this picks up there.

  2. Switch to using knitr chunk options for the panel source and output labels, so that [data-panelset="true"] is always the attribute applied to the panelset chunks. The knitr hooks pick up the panel source and output names.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d18e873) 52.16% compared to head (7b35aba) 52.51%.

Files Patch % Lines
R/panelset.R 72.22% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #193 +/- ## ========================================== + Coverage 52.16% 52.51% +0.35% ========================================== Files 20 20 Lines 784 794 +10 ========================================== + Hits 409 417 +8 - Misses 375 377 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.