gadfly361 / soda-ash

Soda-ash is an interface between clojurescript's Reagent and Semantic UI React
MIT License
152 stars 8 forks source link

quick documentation note #3

Closed paultopia closed 8 years ago

paultopia commented 8 years ago

This is an awesome library, but it might be helpful to people to explicitly point out in the readme that they shouldn't also require reagent in their dependencies. I made that mistake, and the closure compiler puked on advanced compilation, took a while to figure out...

gadfly361 commented 8 years ago

@paultopia Thanks for bringing this up! Instead of not requiring reagent, you should exclude react-with-addons when depending on soda-ash. I added the following to the README:

[soda-ash "0.1.0-beta"
  :exclusions [cljsjs/react-with-addons]]

Also, I strongly recommend not depending on soda-ash yet. I am working on a complete re-write that should 1) provide full class coverage (not just elements), and 2) be much simpler to use ... however, that means the current release is simply useless.