gadget-framework / gadget2

Gadget is the Globally applicable Area Disaggregated General Ecosystem Toolbox
GNU General Public License v2.0
18 stars 20 forks source link

catchstatistic LH and yearly aggregation #4

Open vbartolino opened 8 years ago

vbartolino commented 8 years ago

Is there a reason why CatchStatistics LH does not accept an argument 'aggregationlevel' to aggregate data over the year like for CatchDistribution LH?

Sometimes historical data on weight-at-age are only available on an annual basis in the ICES assessments and this functionality would be pretty useful.

bthe commented 8 years ago

None that I know of, @jmbegley do you remember this?

jmbegley commented 8 years ago

I can't think of any reason either ... I guess that the CatchDistribution likelihood component had a need for a yearly aggregation of the data at some point in the dim and distant past.

It shouldn't be too difficult to implement this, although care would be needed to ensure that the modelled population is aggregated over the year. It's simpler to aggregate the CatchDistribution data than it is to aggregate the modelled population and then calculate the statistics on that population.